gpsbabel.git
18 months agouse container for unicsv fields def. (#1344)
tsteven4 [Thu, 26 Sep 2024 20:59:54 +0000 (14:59 -0600)]
use container for unicsv fields def. (#1344)

and cleanup an extraneous break from #1164.

18 months agocatch gdb debug up with gbfile changes. (#1343)
tsteven4 [Wed, 25 Sep 2024 20:16:57 +0000 (14:16 -0600)]
catch gdb debug up with gbfile changes. (#1343)

* catch gdb debug up with gbfile changes.

* use "if constexpr()" for GDB_DEBUG to detect errors

even if not compiling for debug.

18 months agomore QStrings in gbfile (#1342)
tsteven4 [Wed, 25 Sep 2024 13:35:01 +0000 (07:35 -0600)]
more QStrings in gbfile (#1342)

18 months agorewrite strip_nastyhtml, strip_html in Qt (#1341)
tsteven4 [Mon, 23 Sep 2024 20:06:08 +0000 (14:06 -0600)]
rewrite strip_nastyhtml, strip_html in Qt (#1341)

* rewrite strip_html with QString.

* rewrite strip_nasty_html in Qt.

and actually produce valid html:
1. the replacement for "<body>", "<!   >", is invalid.
2. leaving an html tag in causes the html format output to be invalid.

* cleanup comment xstrdup

* use regex for strip_html

* strip_html deletes other tags

* fix strip_html img tag handling

* Revert "fix strip_html img tag handling"

This reverts commit b0440f7e3729909fd51ecbbacdd7a7e4aa5d9198.

* Revert "strip_html deletes other tags"

This reverts commit 40fe2ef0153d8c2e6d53432b9184f8acffbab2ef.

* Revert "use regex for strip_html"

This reverts commit 677da95a77b335bfa686a35fc33e862f8b50f053.

* implement strip_html using QRegularExpressionMatchIterator.

* a little cleanup

* remove obsolete include

* take care to distinguish tags with common roots

like p, param, pre.

* suppress InvalidReads in qhash.

These are known to occur per comment in qhash.cpp.

* supress qhash false positive with libqt6core6/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64

* suppress vg warnings on noble (intermittant).

* install qt core dbgsyms for valgrind suppression.

* kill space preceding newline when stripping html.

* use modernize-raw-string-literal

* valgrind suppressions for f40

* add symbols for fedora valgrind suppression.

18 months agoremove obsolete mkshort test. (#1340)
tsteven4 [Sat, 14 Sep 2024 13:50:21 +0000 (07:50 -0600)]
remove obsolete mkshort test. (#1340)

The macro TEST_MKSHORT hasn't existed for some time.

18 months agofixes for pr1238. (#1339)
tsteven4 [Sat, 14 Sep 2024 13:02:41 +0000 (07:02 -0600)]
fixes for pr1238. (#1339)

shapelib is handled in shapelib.cmake.
CSVFMTS_ENABLED is now unreferenced.

18 months agoRemove XCSV_ENABLED, MAXIMAL_ENABLED, MINIMAL_ENABLED (#1238)
Robert Lipe [Sat, 14 Sep 2024 12:21:53 +0000 (07:21 -0500)]
Remove XCSV_ENABLED, MAXIMAL_ENABLED, MINIMAL_ENABLED (#1238)

Remove XCSV_ENABLED, MAXIMAL_ENABLED, MINIMAL_ENABLED
---------

Co-authored-by: Robert Lipe <robertlipe@gpsbabel.org>
18 months agoUpdate gpsbabel_man.xml (#1169)
積丹尼 Dan Jacobson [Sat, 14 Sep 2024 05:07:10 +0000 (13:07 +0800)]
Update gpsbabel_man.xml (#1169)

1. add dash, else looks like old tar(1) command.
2. Fix grammar.

Co-authored-by: Robert Lipe <robertlipe@users.noreply.github.com>
18 months agobring back See You support (#1280)
tsteven4 [Sat, 14 Sep 2024 04:48:49 +0000 (22:48 -0600)]
bring back See You support (#1280)

I think someone was waiting for me to say no. Sometimes, "good enough" (for users with no representation here...) seems to be.
Co-authored-by: Robert Lipe <robertlipe@users.noreply.github.com>
18 months agoVarious modernizations in humminbird. (#1100)
Robert Lipe [Sat, 14 Sep 2024 04:18:52 +0000 (23:18 -0500)]
Various modernizations in humminbird. (#1100)

* Various modernizations in humminbird.

- Make humminbird_icons[] a QStringList.
- I don't think the icon finder ever actually worked the way it was described in the
comments.
- Comment fix in exif
- Kill xstrndup (yay)

18 months agomodernize some dynamic memory usage. (#1334)
tsteven4 [Wed, 11 Sep 2024 17:37:25 +0000 (11:37 -0600)]
modernize some dynamic memory usage. (#1334)

* modernize some dynamic memory usage.

* refactor convert_human_[date|time]_format

* convert convert_human_*_format to Qt.

* fix include comment

* use back instead of *rbegin to reference last QChar in QString

18 months agouse persistant docker container for GUI (#1338)
tsteven4 [Wed, 11 Sep 2024 16:29:56 +0000 (10:29 -0600)]
use persistant docker container for GUI (#1338)

18 months agoupdate packages for jammy, noble. (#1337)
tsteven4 [Wed, 11 Sep 2024 15:25:21 +0000 (09:25 -0600)]
update packages for jammy, noble. (#1337)

18 months agocreate docker images with historical releases. (#1336)
tsteven4 [Tue, 10 Sep 2024 18:28:02 +0000 (12:28 -0600)]
create docker images with historical releases. (#1336)

* create docker images with historical releases.

* add scripts to automate image creation

* enhance test script to avoid cwd dependencies.

* move 1.7.0 base from focal to jammy

* make sure to clean up container

* make sure container is cleaned up.

* fix varaible use in arithmetic context

* delete unused archive from images.

* don't confuse our zlib and system zlib

* use system zlib shapelib for 1.8.0, 1.9.0

* add script to run GUI

* fix up 1.5.x plugins.

these were probematic for 1.5.4, previous releases ran ok with webkit.
translations don't work for 1.5.x

* shellcheck

* enhance GUI run script to forward LANG

* add bleeding edge image.

18 months agoMerge pull request #1335 from GPSBabel/tidymore
tsteven4 [Fri, 6 Sep 2024 13:35:35 +0000 (07:35 -0600)]
Merge pull request #1335 from GPSBabel/tidymore

clang tidy fixes

18 months agofix tidy modernize-use-nullptr
tsteven4 [Thu, 5 Sep 2024 13:40:38 +0000 (07:40 -0600)]
fix tidy modernize-use-nullptr

18 months agofix tidy readability-duplicate-include
tsteven4 [Thu, 5 Sep 2024 13:39:45 +0000 (07:39 -0600)]
fix tidy readability-duplicate-include

18 months agofix tidy modernize-raw-string-literal
tsteven4 [Thu, 5 Sep 2024 13:38:41 +0000 (07:38 -0600)]
fix tidy modernize-raw-string-literal

18 months agofix tidy readability-avoid-const-params-in-decls
tsteven4 [Thu, 5 Sep 2024 13:37:45 +0000 (07:37 -0600)]
fix tidy readability-avoid-const-params-in-decls

18 months agooptimize [QDate|QTime|QDateTime]::fromString format literals. (#1278)
tsteven4 [Wed, 4 Sep 2024 17:51:18 +0000 (11:51 -0600)]
optimize [QDate|QTime|QDateTime]::fromString format literals. (#1278)

* optimize [QDate|QTime|QDateTime]::fromString format literals.

These accept QStringViews in Qt6 which can be very efficiently
passed with UTF-16 character literals.

* optimize QDateTime::toString format literals.

This isn't new to Qt6, but we had a few we hadn't taken care of
yet.

* use QString::replace(QChar, QChar) instead of (QString, QString)

19 months agokill a position normilization clone caught by codacy. (#1333)
tsteven4 [Fri, 30 Aug 2024 23:32:15 +0000 (17:32 -0600)]
kill a position normilization clone caught by codacy. (#1333)

19 months agonormalize waypoint position. (#1331)
tsteven4 [Fri, 30 Aug 2024 23:11:09 +0000 (17:11 -0600)]
normalize waypoint position. (#1331)

19 months agoprevent assertion failures in nmea reader (#1332)
tsteven4 [Fri, 30 Aug 2024 22:31:11 +0000 (16:31 -0600)]
prevent assertion failures in nmea reader (#1332)

* replace all empty nmea fields with 0.

including adjacent empty fileds, i.e. ",,," -> ",0,0,".

* defend against indexing past end of arrays.

prevents assertion failures in qstring.h operator[].

also consistently default longitude direction.

19 months agoHumminbirdhash (#1327)
tsteven4 [Mon, 19 Aug 2024 23:33:07 +0000 (17:33 -0600)]
Humminbirdhash (#1327)

* refactor humminbird handling of wpt numbers.

also:
convert some macros to constexpr.
consistenly use strncpy to move strings to humminbird char arrays.`

* fix clang-diagnostic-missing-field-initializers

19 months agoclang-tidy-18 fixes performance-unnecessary-copy-initialization (#1328)
tsteven4 [Mon, 19 Aug 2024 22:47:13 +0000 (16:47 -0600)]
clang-tidy-18 fixes performance-unnecessary-copy-initialization (#1328)

19 months agoZap repeated examples (#1084)
積丹尼 Dan Jacobson [Sun, 18 Aug 2024 22:24:12 +0000 (06:24 +0800)]
Zap repeated examples (#1084)

On https://www.gpsbabel.org/htmldoc-development/fmt_globalsat.html
we observe these two examples are repeated further down, in context too. So they shouldn't also
appear higher up.

I am guessing that I have correctly zapped the higher up pair.

Co-authored-by: Robert Lipe
19 months agosimplify osm_tag option processing. (#1325)
tsteven4 [Sat, 17 Aug 2024 17:37:13 +0000 (11:37 -0600)]
simplify osm_tag option processing. (#1325)

I suspect the check of "tagnd" was used in developement before
opt_tagnd was added.  The only thing the check did was ignore
opt_tag values that started with tagnd, they weren't used elsewhere.

19 months agoadd fix & test for humminbird route writer. (#1324)
tsteven4 [Fri, 16 Aug 2024 01:45:38 +0000 (19:45 -0600)]
add fix & test for humminbird route writer. (#1324)

The missing initialization was introduced in 824e01d.

19 months agoupdate shapelib to 1.6.1 (#1323)
tsteven4 [Thu, 15 Aug 2024 11:50:46 +0000 (05:50 -0600)]
update shapelib to 1.6.1 (#1323)

19 months agoModernize Humminbird internals (#1322)
Robert Lipe [Thu, 15 Aug 2024 05:51:56 +0000 (00:51 -0500)]
Modernize Humminbird internals (#1322)

* Modernize Humminbirds internals

---------

Co-authored-by: Robert Lipe <robertlipe@gpsbabel.org>
19 months agouse implicit conversions for lat,lon degs<->rads in grtcirc interface (#1321)
tsteven4 [Tue, 13 Aug 2024 20:21:31 +0000 (14:21 -0600)]
use implicit conversions for lat,lon degs<->rads in grtcirc interface (#1321)

* use implict conversions for lat,lon degs<->rads.

* use Position* return values.

* convert grtcirc i/f to PositionDeg, PositionRad.

* fix mac compile, denote converting ctor.

* inline PositionDeg/Rad converting ctors.

* respect PosotionX encapsulation.

* differentiate member names for PositionDeg, PositiionRad.  This can catch unintended usages where the type is not what was expected.

* clean up unneccesary usage of Waypoint::position.

* delete obsolete declaration.

* spell

* update garmin include

* consistenly unpack Positions to consts in grtcirc.

* provide default initializers for PositionX.

19 months agofix bend filter usage of linepart. (#1320)
tsteven4 [Mon, 12 Aug 2024 20:24:28 +0000 (14:24 -0600)]
fix bend filter usage of linepart. (#1320)

* fix bend filter usage of linepart.

* fix new bend filter test.

* make new reference files valid kml.

* debug macos fails

* workaround rounding errors in problematic kml lookat range.

19 months agocleanup great circle. (#1318)
tsteven4 [Mon, 12 Aug 2024 13:05:53 +0000 (07:05 -0600)]
cleanup great circle. (#1318)

* cleanup great circle.

* fix whitespace

19 months agocorrect simplify filter with maximum allowable error option and the metric being...
tsteven4 [Mon, 12 Aug 2024 12:37:08 +0000 (06:37 -0600)]
correct simplify filter with maximum allowable error option and the metric being overall route length or relative error (#1316)

* add test for simplify w/ relative+error opts.

* fix simplify filter error+length operation.

* fix simplify relative+error

* remove debug statement

* simplify error unit tests and documentation.

* format parse, update includes.

* prune redundant test case

19 months agohave jeeps use std::endian (#1315)
tsteven4 [Sat, 10 Aug 2024 20:23:50 +0000 (14:23 -0600)]
have jeeps use std::endian (#1315)

* have jeeps use std::endian

* detect unsupported endian platforms.

19 months agomove floor to C++20 (#1206)
tsteven4 [Fri, 9 Aug 2024 23:02:46 +0000 (17:02 -0600)]
move floor to C++20 (#1206)

* move floor to c++20

drop Visual Studio 2017.
use default member intializers for bit-fields.

* use more bit-field default initializers

* try Xcod 14.3.1 on macOS 13.

* echo clang version

which can be useful with homebrew fails_with

* use std::numbers

* finish eradication of M_PI.

* fix some whitespace

19 months agouse constexpr for constants, match parms in declaration and definition. (#1314)
tsteven4 [Thu, 8 Aug 2024 20:33:29 +0000 (14:33 -0600)]
use constexpr for constants, match parms in declaration and definition. (#1314)

* use constexpr for constants, match parms in declaration and definition.

* increase precision of GPS_PI.

19 months agoUse Helmert transform for conversions between OSGB36 and WSG84 (#1311)
tsteven4 [Thu, 8 Aug 2024 16:07:18 +0000 (10:07 -0600)]
Use Helmert transform for conversions between OSGB36 and WSG84 (#1311)

* use Helmert transform for OSBG36 <-> WGS84.

* adjust unicsv_grids reference for Helmert xform.

* update copyright.

* use constexpr to select helmert inversion method.

* tweak helmert.

19 months agospell Datum (#1313)
tsteven4 [Wed, 7 Aug 2024 22:30:29 +0000 (16:30 -0600)]
spell Datum (#1313)

19 months agounify access to ellipsoid parameters (#1312)
tsteven4 [Wed, 7 Aug 2024 21:04:13 +0000 (15:04 -0600)]
unify access to ellipsoid parameters (#1312)

* define constants for often used spherioid parms.

* add function to calculate semi-minor axis.

* use semi major axis function more.

* have semi_minor_axis consume an ellipse

* compute semi minor axis in GPS_Ellipse class.

add constants for other ellipses that are used directly.

19 months agocorrect WGS84 semi minor axis value. (#1310)
tsteven4 [Tue, 6 Aug 2024 19:12:58 +0000 (13:12 -0600)]
correct WGS84 semi minor axis value. (#1310)

It appears the GSR80 value was used instead of the WGS84 value, which
is a very small error.
However, there was a typo in the value in GPS_Math_XYZ_To_WGS84LatLonH
that resulted in an order of magnitude error!
This could lead to GPS_Math_XYZ_To_WGS84LatLonH never converging.
This may be why skytraq created their own function to convert ECEF
to WGS84.

20 months agocleanup datetime.h tidy and g++ warnings. (#1309)
tsteven4 [Fri, 2 Aug 2024 12:43:27 +0000 (06:43 -0600)]
cleanup datetime.h tidy and g++ warnings. (#1309)

Wsign-conversion
readability-implicit-bool-conversion
readability-else-after-return
cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers

20 months agoenhance validate filter to report on track segments. (#1308)
tsteven4 [Thu, 1 Aug 2024 12:52:03 +0000 (06:52 -0600)]
enhance validate filter to report on track segments. (#1308)

20 months agouse a signed type for waypt_counts and route counts. (#1307)
tsteven4 [Tue, 30 Jul 2024 23:31:08 +0000 (17:31 -0600)]
use a signed type for waypt_counts and route counts. (#1307)

* use a signed type for waypt_counts and route counts.

Although larger in Qt6, the underlying type is signed.

* fix -Wformat-signedness warnings introduced by this PR.

* fix new -Wsign-conversion warnings.

20 months agoteach lowranceusr about track segments (#1306)
tsteven4 [Sat, 27 Jul 2024 18:02:57 +0000 (12:02 -0600)]
teach lowranceusr about track segments (#1306)

* teach lowranceusr about track segments.

lowranceusr versions 2 & 3 have a continuous flag used to
indicate dicontinuities in a trail.
The lowranceusr version 2 & 3 reader now flags trail discontinuities
as new track segements.
The lowranceusr version 2 & 3 writer now flags new track segments as
discontinuities.

Also fix two subtle bugs:
1) when reading a version 2 or 3 trail with the break option we would
fail to break the trail if the discontinuity was at the start of a
section other than the first section.
2) when writing a version 2 or 3 trail with the merge option if the
number of points exceeded MAX_TRAIL_POINTS we would write a header
that indicated MAX_TRAIL_POINTS but actually write MAX_TRAIL_POINTS + 1.

* add lowranceusr test for track segments.

20 months agoUpdate Russian translation (#1304)
OlesyaGerasimenko [Wed, 24 Jul 2024 13:37:46 +0000 (16:37 +0300)]
Update Russian translation (#1304)

* Update Russian translation

* Update Russian translation

20 months agocorrect garmin real time altitude, add geoid height. (#1303)
tsteven4 [Tue, 23 Jul 2024 20:57:25 +0000 (14:57 -0600)]
correct garmin real time altitude, add geoid height. (#1303)

20 months agocorrect computation of timestamp with garmin real time positioning. (#1302)
tsteven4 [Mon, 22 Jul 2024 19:21:05 +0000 (13:21 -0600)]
correct computation of timestamp with garmin real time positioning. (#1302)

* correct computation of timestamp with garmin real time positioning.

* tweak garmin pvt conversion

20 months agofix gpsapp copy_char_array that could leave part of a packet uninitialized. (#1301)
tsteven4 [Sat, 20 Jul 2024 17:35:52 +0000 (11:35 -0600)]
fix gpsapp copy_char_array that could leave part of a packet uninitialized. (#1301)

* fix gpsapp copy_char_array that could leave part of a packet uninitialized.

* tidy up a bit.

* delete empty statement

20 months agofix memory leaks writing garmin routes. (#1299)
tsteven4 [Sat, 20 Jul 2024 12:48:06 +0000 (06:48 -0600)]
fix memory leaks writing garmin routes. (#1299)

20 months agoenhance garmin route write for devices using 16 member icon set. (#1298)
tsteven4 [Fri, 19 Jul 2024 13:11:59 +0000 (07:11 -0600)]
enhance garmin route write for devices using 16 member icon set. (#1298)

20 months agoenhance garmin route writes for devices using D201_Rte_Hdr_Type. (#1297)
tsteven4 [Fri, 19 Jul 2024 12:52:44 +0000 (06:52 -0600)]
enhance garmin route writes for devices using D201_Rte_Hdr_Type. (#1297)

which use GPS_PWay->rte_cmnt for the route name.

20 months agodon't send links with GPS_A200_Send. (#1295)
tsteven4 [Fri, 19 Jul 2024 11:53:30 +0000 (05:53 -0600)]
don't send links with GPS_A200_Send. (#1295)

20 months agofix faulty assertion in garmin. (#1290)
tsteven4 [Sat, 13 Jul 2024 21:56:45 +0000 (15:56 -0600)]
fix faulty assertion in garmin. (#1290)

the '-' character is legal for some devices, but was
excluded in the assertions as it can be a metacharacter.

21 months agoremove qtci installer code (#1289)
tsteven4 [Mon, 1 Jul 2024 21:11:02 +0000 (15:11 -0600)]
remove qtci installer code (#1289)

* remove qtci which hasn't been used for a long time.

* remove another obsolete qtci file.

* remove another qtci reference.

* delete obsolete travis build code.

* rename osx install script

* catch ci up with osx travis install script renames.

* remove obsolete debug code from qtio installer.

21 months agoexclude qt .ts files from codacy analysis. (#1288)
tsteven4 [Sat, 29 Jun 2024 19:17:01 +0000 (13:17 -0600)]
exclude qt .ts files from codacy analysis. (#1288)

they confuse eslint which thinks they are TypeScript.

21 months agoFix unicsv reader delimiter detection (#1287)
tsteven4 [Sat, 29 Jun 2024 18:49:56 +0000 (12:49 -0600)]
Fix unicsv reader delimiter detection (#1287)

* Fix unicsv reader delimiter detection.

Any delimiter sequence that is enclosed has never been considered
a delimiter when splitting a line into fields.  However, previously
an enclosed potential delimiter could be detected when scanning the
first line, and then erroneously used as the delimiter.

* tweak auto

* add unicsv delimiter detection test

21 months agodelete obsolete jeeps functions that were never used (#1285)
tsteven4 [Wed, 12 Jun 2024 20:54:29 +0000 (14:54 -0600)]
delete obsolete jeeps functions that were never used (#1285)

since introduction in 2002.

21 months agoupdate macos release to Qt 6.5.3 (#1284)
tsteven4 [Wed, 5 Jun 2024 22:41:10 +0000 (16:41 -0600)]
update macos release to Qt 6.5.3 (#1284)

22 months agorefactor interface to jeeps pvt related commands. (#1283)
tsteven4 [Thu, 23 May 2024 15:55:06 +0000 (09:55 -0600)]
refactor interface to jeeps pvt related commands. (#1283)

22 months agofix xcsv RECORD_DELIMITER CR. (#1282)
tsteven4 [Mon, 20 May 2024 14:12:52 +0000 (08:12 -0600)]
fix xcsv RECORD_DELIMITER CR. (#1282)

22 months agoadd Qt's webengine translations to package. (#1277)
tsteven4 [Sun, 5 May 2024 22:36:31 +0000 (16:36 -0600)]
add Qt's webengine translations to package. (#1277)

23 months agotidy readability-convert-member-functions-to-static (#1276)
tsteven4 [Sat, 4 May 2024 21:39:21 +0000 (15:39 -0600)]
tidy readability-convert-member-functions-to-static (#1276)

23 months agoclang-tidy modernize-loop-convert (#1275)
tsteven4 [Sat, 4 May 2024 17:53:36 +0000 (11:53 -0600)]
clang-tidy modernize-loop-convert (#1275)

23 months agoclang-tidy readability-isolate-declaration (#1274)
tsteven4 [Sat, 4 May 2024 16:48:07 +0000 (10:48 -0600)]
clang-tidy readability-isolate-declaration (#1274)

23 months agoMove floor to Qt 6.2 (#1272)
tsteven4 [Sat, 4 May 2024 15:53:15 +0000 (09:53 -0600)]
Move floor to Qt 6.2 (#1272)

* move floor from Qt 5.15 to 6.2.

* fix some CI failures

* try harder to fix coverage build

* try to fix coverage again

* try agin

* move up msvc tools minimum for Qt6

* clean up clazy warnings with Qt6.

* drop redundnant CI job

* revert translation related unintentionl changes

* simplify find qt packages

* assume Qt6 in textstream

* move CI tidy to noble

* assume Qt6 in textstream.h

* remove obsolete makesetup.bat

* remove Qt5 support from coretool

* strip Qt5 from noble image

* update default qt versions.

* update minimum cmake version to match Qt 6.2.4 QT_SUPPORTED_MIN_CMAKE_VERSION_FOR_USING_QT

* assume QHash result is type size_t

* remove unnecessary qOverloads (in Qt6).

23 months agoadd Ubuntu noble to CI (#1273)
tsteven4 [Sat, 27 Apr 2024 19:35:28 +0000 (13:35 -0600)]
add Ubuntu noble to CI (#1273)

* add ubuntu noble docker support

* update qt6 packages for noble.

noble has some new qt6 packages that alleviate the need to
directly install some libraries.
also, the dependencies of some qt6 packages have been improved
allowing us to specify what we use more directly.
this results in the same set of packges being installed.

* remove dependent qt5 package

* add noble to CI

23 months agoadd fedora 40 to CI (#1270)
tsteven4 [Tue, 23 Apr 2024 21:54:49 +0000 (15:54 -0600)]
add fedora 40 to CI (#1270)

23 months agosupport builds with shapelib (as documented). (#1268)
tsteven4 [Thu, 18 Apr 2024 11:34:22 +0000 (05:34 -0600)]
support builds with shapelib (as documented). (#1268)

23 months agoupdate libusb to 1.0.27 (#1259)
tsteven4 [Tue, 16 Apr 2024 14:09:53 +0000 (08:09 -0600)]
update libusb to 1.0.27 (#1259)

23 months agowork around homebrew python linking issues (#1267)
tsteven4 [Tue, 16 Apr 2024 13:35:04 +0000 (07:35 -0600)]
work around homebrew python linking issues (#1267)

* debug python brew issues

* dbg2

* dbg3

* dbg4

* insulate workflow from homebrew location.

23 months agoAdd test coverage for ozi color setting options. (#1266)
GPSBabel [Sun, 14 Apr 2024 08:12:11 +0000 (03:12 -0500)]
Add test coverage for ozi color setting options. (#1266)

* Unit test ozi color commandline options.

Improves test coverage.

Co-authored-by: Robert Lipe
23 months agoupdate macos github workflow (#1265)
tsteven4 [Thu, 11 Apr 2024 12:24:55 +0000 (06:24 -0600)]
update macos github workflow (#1265)

* update github macos runners.

macos-11 runner is now deprecated.

* update xcode versions for github

* update XML_CATALOG_FILES for macos-14 runner

* work around macos-14 runner brew locations

* find homebrew gsed on apple silicon

* generalize brew location detection in macos workflow

* update python version for arm availability

* push xcode versions to latest minor levels.

2 years agoclang tidy 18 fixes readability-redundant-casting (#1262)
tsteven4 [Fri, 8 Mar 2024 18:42:01 +0000 (11:42 -0700)]
clang tidy 18 fixes readability-redundant-casting (#1262)

2 years agoupdate zlib to 1.3.1 (#1258)
tsteven4 [Wed, 7 Feb 2024 21:57:17 +0000 (14:57 -0700)]
update zlib to 1.3.1 (#1258)

* update zlib to 1.3.1

* delete extra zlib files

2 years agoupdate shapelib to 1.6.0 (#1257)
tsteven4 [Thu, 25 Jan 2024 16:14:44 +0000 (09:14 -0700)]
update shapelib to 1.6.0 (#1257)

2 years agoBump actions/cache from 3 to 4 (#1256)
dependabot[bot] [Wed, 24 Jan 2024 17:42:05 +0000 (10:42 -0700)]
Bump actions/cache from 3 to 4 (#1256)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years agoupdate codacy badge (#1251)
tsteven4 [Sat, 23 Dec 2023 14:22:07 +0000 (07:22 -0700)]
update codacy badge (#1251)

2 years agoupdate codeql workflow template (#1250)
tsteven4 [Mon, 18 Dec 2023 17:13:36 +0000 (10:13 -0700)]
update codeql workflow template (#1250)

2 years agoBump actions/upload-artifact from 3 to 4 (#1249)
dependabot[bot] [Mon, 18 Dec 2023 16:52:23 +0000 (09:52 -0700)]
Bump actions/upload-artifact from 3 to 4 (#1249)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years agoBump github/codeql-action from 2 to 3 (#1248)
dependabot[bot] [Mon, 18 Dec 2023 16:02:24 +0000 (09:02 -0700)]
Bump github/codeql-action from 2 to 3 (#1248)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years agomodernize google maps javascript (#1247)
tsteven4 [Mon, 18 Dec 2023 13:17:09 +0000 (06:17 -0700)]
modernize google maps javascript (#1247)

to avoid:
"js: Google Maps JavaScript API has been loaded directly without a callback. This is not supported and can lead to race conditions and suboptimal performance. For supported loading patterns please see https://goo.gle/js-api-loading"

2 years agoremove CMakeSettings.json (#1246)
tsteven4 [Sat, 16 Dec 2023 15:20:43 +0000 (08:20 -0700)]
remove CMakeSettings.json (#1246)

which had machine specific windows configuration values.

2 years agoBump actions/setup-python from 4 to 5 (#1245)
dependabot[bot] [Mon, 11 Dec 2023 15:26:12 +0000 (08:26 -0700)]
Bump actions/setup-python from 4 to 5 (#1245)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years agomake xmlgeneric a class (#1244)
tsteven4 [Thu, 30 Nov 2023 12:40:13 +0000 (05:40 -0700)]
make xmlgeneric a class (#1244)

* make xmlgeneric a class.

* encapsulate more of xmlgeneric

* use scoped enum

* encapsulate a bit more.

* retire xg_string type

* use scoped enums

* rule of zero applied to xmlgeneric class.

* remove test code

2 years agofix errors in gpi writer related to bitmaps. (#1243)
tsteven4 [Thu, 23 Nov 2023 14:22:05 +0000 (07:22 -0700)]
fix errors in gpi writer related to bitmaps. (#1243)

Erroneous warnings "garmin_gpi: Code error in load_bitmap_from_file,
expected output size 1060, actual output -28."

Corrupted colors when input bitmap has 24 bits per pixel.

2 years agobring static functions into googltakeout class. (#1240)
tsteven4 [Thu, 23 Nov 2023 13:24:49 +0000 (06:24 -0700)]
bring static functions into googltakeout class. (#1240)

and other tidy modernizations.

2 years agostraggling nits (#1236)
tsteven4 [Mon, 20 Nov 2023 18:01:17 +0000 (11:01 -0700)]
straggling nits (#1236)

* actually quit using gpsfmt.h

* use auto

* empty statements

* join declaration and assignment

* fix tab

* make member funct static

* delete renamed prototypes

* const pointers

* more const pointers

* empty statements

2 years agomisc cleanups (#1235)
tsteven4 [Sun, 19 Nov 2023 13:00:31 +0000 (06:00 -0700)]
misc cleanups (#1235)

2 years agosimplify usage of homebrew on CI macos-11. (#1234)
tsteven4 [Sun, 19 Nov 2023 02:36:42 +0000 (19:36 -0700)]
simplify usage of homebrew on CI macos-11. (#1234)

homebrew installs are taking an extreme amount of time on macos-11,
with the following message:
  Warning: You are using macOS 11.
  We (and Apple) do not provide support for this old version.
  It is expected behaviour that some formulae will fail to build in this old version.
  It is expected behaviour that Homebrew will be buggy and slow.
To alleviate this pain skip the installation of jing and all it's
dependencies on macos-11.

2 years agoretire LegacyFormat class. (#1233)
tsteven4 [Sun, 19 Nov 2023 02:07:36 +0000 (19:07 -0700)]
retire LegacyFormat class. (#1233)

2 years agoconvert mtk formats to Format class. (#1226)
tsteven4 [Sun, 19 Nov 2023 01:42:53 +0000 (18:42 -0700)]
convert mtk formats to Format class. (#1226)

2 years agoconvert ozi to Format class. (#1232)
tsteven4 [Sun, 19 Nov 2023 01:18:04 +0000 (18:18 -0700)]
convert ozi to Format class. (#1232)

* convert ozi to Format class.

There is a subtle difference in the writer, the index is now
reset for every invocation.  This only matters if the writer is
used more than once. I believe this was the intent.

* fool with QIODevice and it's inheritence of QIODeviceBase.

2 years agoconvert garmin_txt to Format class (#1231)
tsteven4 [Sun, 19 Nov 2023 00:49:24 +0000 (17:49 -0700)]
convert garmin_txt to Format class (#1231)

* convert garmin_txt to Format class

* fix includes for qt5

2 years agoconvert garmin_xt to Format class (#1230)
tsteven4 [Sat, 18 Nov 2023 23:28:47 +0000 (16:28 -0700)]
convert garmin_xt to Format class (#1230)

2 years agoconvert tpg to dynamic Format class. (#1229)
tsteven4 [Sat, 18 Nov 2023 22:16:01 +0000 (15:16 -0700)]
convert tpg to dynamic Format class. (#1229)

2 years agoconvert gtm to Format class. (#1228)
tsteven4 [Sat, 18 Nov 2023 21:47:09 +0000 (14:47 -0700)]
convert gtm to Format class. (#1228)

2 years agoconvert v900 to dynamic Format class. (#1227)
tsteven4 [Sat, 18 Nov 2023 21:08:26 +0000 (14:08 -0700)]
convert v900 to dynamic Format class. (#1227)

2 years agoconvert tpo formats to Format class (#1225)
tsteven4 [Sat, 18 Nov 2023 13:59:38 +0000 (06:59 -0700)]
convert tpo formats to Format class (#1225)

* convert tpo to Format class.

* capture comments

2 years agofix leak in jeeps serial comm on posix. (#1223)
tsteven4 [Thu, 16 Nov 2023 21:30:05 +0000 (14:30 -0700)]
fix leak in jeeps serial comm on posix. (#1223)

see #1221